[
https://issues.apache.org/jira/browse/GOBBLIN-1713?focusedWorklogId=811487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811487
]
ASF GitHub Bot logged work on GOBBLIN-1713:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/22 04:50
Start Date: 23/Sep/22 04:50
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3567:
URL: https://github.com/apache/gobblin/pull/3567#discussion_r978263141
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlBaseSpecStore.java:
##########
@@ -325,6 +327,7 @@ protected <T> T withPreparedStatement(String sql,
CheckedFunction<PreparedStatem
}
return result;
} catch (SQLException e) {
+ log.warn("Received SQL exception that can result from invalid
connection. Checking if validation query is set {} Exception is {}",
((BasicDataSource) this.dataSource).getValidationQuery());
Review Comment:
you forgot the exception parameter
Issue Time Tracking
-------------------
Worklog Id: (was: 811487)
Time Spent: 1h 20m (was: 1h 10m)
> Add validation check for mysql connection
> ------------------------------------------
>
> Key: GOBBLIN-1713
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1713
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Detect once a MySQL connection becomes read-only. Enforce verification when
> this happens, so we know to create new, replacement connections (to a
> read-write host). Adding this check to a code path that was missing this
> check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
