phet commented on code in PR #3567:
URL: https://github.com/apache/gobblin/pull/3567#discussion_r978012393
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/jdbc/DataSourceProvider.java:
##########
@@ -81,6 +81,8 @@ public DataSourceProvider(@Named("dataSourceProperties")
Properties properties)
}
public DataSourceProvider() {
+ LOG.warn("Creating {} without setting validation query. Stacktrace of
current thread {}",
+ this.getClass().getSimpleName(),
Thread.currentThread().getStackTrace());
Review Comment:
because this is a `StackTraceElement[]`, `.toString` will be ugly. you may
want something like:
```
Arrays.toString(st).replace(", ", "\n at ")
```
or
```
String.join("\n at", st.stream().map(x -> x.toString()).collect(...))
```
##########
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/JobHistoryDataSourceProvider.java:
##########
@@ -33,6 +33,7 @@ public class JobHistoryDataSourceProvider extends
org.apache.gobblin.util.jdbc.D
@Inject
public JobHistoryDataSourceProvider(@Named("dataSourceProperties")
Properties properties) {
+ super(properties);
Review Comment:
line 40 and 41 look like they guard the call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
