umustafi commented on code in PR #3567:
URL: https://github.com/apache/gobblin/pull/3567#discussion_r978865161
##########
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/JobHistoryDataSourceProvider.java:
##########
@@ -17,24 +17,42 @@
package org.apache.gobblin.metastore;
+import java.time.Duration;
import java.util.Properties;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import com.google.inject.Inject;
import com.google.inject.name.Named;
import org.apache.gobblin.configuration.ConfigurationKeys;
import org.apache.gobblin.password.PasswordManager;
+import org.apache.gobblin.util.jdbc.DataSourceProvider;
+import org.apache.gobblin.util.jdbc.MysqlDataSourceUtils;
/**
* This class extends {@link org.apache.gobblin.util.jdbc.DataSourceProvider}
with its own property keys.
*/
public class JobHistoryDataSourceProvider extends
org.apache.gobblin.util.jdbc.DataSourceProvider {
+ private static final Logger LOG =
LoggerFactory.getLogger(DataSourceProvider.class);
Review Comment:
the other classes use logger factory so sticking with that although @sl4j
also works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
