[
https://issues.apache.org/jira/browse/GOBBLIN-1720?focusedWorklogId=824106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824106
]
ASF GitHub Bot logged work on GOBBLIN-1720:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/22 06:24
Start Date: 08/Nov/22 06:24
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3577:
URL: https://github.com/apache/gobblin/pull/3577#discussion_r1016186662
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -144,13 +146,17 @@ Collection<CopyEntity> generateCopyEntities(FileSystem
targetFs, CopyConfigurati
FileStatus srcFileStatus = entry.getValue();
// TODO: should be the same FS each time; try creating once, reusing
thereafter, to not recreate wastefully
FileSystem actualSourceFs =
getSourceFileSystemFromFileStatus(srcFileStatus, defaultHadoopConfiguration);
+ Path greatestAncestorPath = PathUtils.getRootPathChild(srcPath);
- // TODO: Add preservation of ancestor ownership and permissions!
-
+ // preserving ancestor permissions till root path's child between src
and dest
+ List<OwnerAndPermission> ancestorOwnerAndPermission =
Review Comment:
added suffix `list` to the variable name
Issue Time Tracking
-------------------
Worklog Id: (was: 824106)
Time Spent: 1h 20m (was: 1h 10m)
> Preserve Ancestor Owner and Permissions for Fs between Src and Dest for
> Iceberg Distcp
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1720
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1720
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We want to preserve the Fs ownership and permissions between src and dest
> while performing an Iceberg based distcp. Currently, we are preserving all
> the permissions up to root dir for Iceberg tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
