[
https://issues.apache.org/jira/browse/GOBBLIN-1720?focusedWorklogId=824386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824386
]
ASF GitHub Bot logged work on GOBBLIN-1720:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/22 00:45
Start Date: 09/Nov/22 00:45
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3577:
URL: https://github.com/apache/gobblin/pull/3577#discussion_r1017273006
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetTest.java:
##########
@@ -307,105 +329,137 @@ protected IcebergTable
validateGetFilePathsGivenDestState(
/** @return `paths` after adding to it all paths of every one of
`snapshotDefs` */
protected static Set<Path> withAllSnapshotPaths(Set<Path> paths,
MockIcebergTable.SnapshotPaths... snapshotDefs) {
Arrays.stream(snapshotDefs).flatMap(snapshotDef ->
- snapshotDef.asSnapshotInfo().getAllPaths().stream()
- ).forEach(p ->
- paths.add(new Path(p))
- );
+ snapshotDef.asSnapshotInfo().getAllPaths().stream())
+ .forEach(p ->
+ paths.add(new Path(p))
+ );
return paths;
}
private CopyConfiguration createEmptyCopyConfiguration(FileSystem fs) {
- return CopyConfiguration.builder(fs, copyConfigProperties)
- .copyContext(new CopyContext())
- .build();
+ return CopyConfiguration.builder(fs, copyConfigProperties).copyContext(new
CopyContext()).build();
}
private static void verifyCopyEntities(Collection<CopyEntity> copyEntities,
List<String> expected) {
- List<String> actual = new ArrayList<>();
+ Set<String> actual = new HashSet<>();
Review Comment:
I wanted to leverage `contains` method from HashSet, but I no longer need
it. Have changed it back to List
Issue Time Tracking
-------------------
Worklog Id: (was: 824386)
Time Spent: 1h 50m (was: 1h 40m)
> Preserve Ancestor Owner and Permissions for Fs between Src and Dest for
> Iceberg Distcp
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1720
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1720
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We want to preserve the Fs ownership and permissions between src and dest
> while performing an Iceberg based distcp. Currently, we are preserving all
> the permissions up to root dir for Iceberg tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
