[
https://issues.apache.org/jira/browse/GOBBLIN-1743?focusedWorklogId=826997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826997
]
ASF GitHub Bot logged work on GOBBLIN-1743:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/22 00:07
Start Date: 18/Nov/22 00:07
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3602:
URL: https://github.com/apache/gobblin/pull/3602
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1743
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
this PR https://github.com/apache/gobblin/pull/3519/files has a call to
Helix cluster contained outside of a conditional that was previously never
encountered for use cases without yarn. I moved the call back inside the
conditional to ensure we don't attempt to retrieve an instanceConfig that is
not registered with Helix as we don't have Yarn mode enabled.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 826997)
Remaining Estimate: 0h
Time Spent: 10m
> Ensure GobblinTaskRunner works when used without Yarn
> -----------------------------------------------------
>
> Key: GOBBLIN-1743
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1743
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> this PR [https://github.com/apache/gobblin/pull/3519/files] has a call to
> Helix cluster contained outside of a conditional that was previously never
> encountered for Fliptop use case. I moved the call back inside the
> conditional to ensure we don't attempt to retrieve an instanceConfig that is
> not registered with Helix as we don't have Yarn mode enabled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
