[
https://issues.apache.org/jira/browse/GOBBLIN-1743?focusedWorklogId=827001&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827001
]
ASF GitHub Bot logged work on GOBBLIN-1743:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/22 00:19
Start Date: 18/Nov/22 00:19
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3602:
URL: https://github.com/apache/gobblin/pull/3602#issuecomment-1319383528
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3602?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3602](https://codecov.io/gh/apache/gobblin/pull/3602?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0888d7f) into
[master](https://codecov.io/gh/apache/gobblin/commit/4e7317cb1c17181bc4f6ec2c46fae27eca8203d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(4e7317c) will **decrease** coverage by `3.04%`.
> The diff coverage is `14.28%`.
```diff
@@ Coverage Diff @@
## master #3602 +/- ##
============================================
- Coverage 46.90% 43.86% -3.05%
+ Complexity 10672 2063 -8609
============================================
Files 2120 408 -1712
Lines 83101 17624 -65477
Branches 9255 2154 -7101
============================================
- Hits 38979 7730 -31249
+ Misses 40549 9037 -31512
+ Partials 3573 857 -2716
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `62.50% <14.28%> (-1.14%)` | :arrow_down: |
|
[.../gobblin/cluster/GobblinHelixTaskStateTracker.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza1N0YXRlVHJhY2tlci5qYXZh)
| `62.50% <0.00%> (-6.25%)` | :arrow_down: |
|
[.../java/org/apache/gobblin/cluster/SleepingTask.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2xlZXBpbmdUYXNrLmphdmE=)
| `39.39% <0.00%> (-6.07%)` | :arrow_down: |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.29% <0.00%> (-0.66%)` | :arrow_down: |
|
[...time/instance/StandardGobblinInstanceLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvaW5zdGFuY2UvU3RhbmRhcmRHb2JibGluSW5zdGFuY2VMYXVuY2hlci5qYXZh)
| | |
|
[...rce/extractor/extract/kafka/KafkaSimpleSource.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYVNpbXBsZVNvdXJjZS5qYXZh)
| | |
|
[...\_catalog/PackagedTemplatesJobCatalogDecorator.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX2NhdGFsb2cvUGFja2FnZWRUZW1wbGF0ZXNKb2JDYXRhbG9nRGVjb3JhdG9yLmphdmE=)
| | |
|
[.../service/modules/orchestration/AzkabanSuccess.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9BemthYmFuU3VjY2Vzcy5qYXZh)
| | |
|
[...ava/org/apache/gobblin/runtime/util/GsonUtils.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Hc29uVXRpbHMuamF2YQ==)
| | |
|
[...org/apache/gobblin/source/jdbc/MysqlExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL015c3FsRXh0cmFjdG9yLmphdmE=)
| | |
| ... and [1709
more](https://codecov.io/gh/apache/gobblin/pull/3602/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 827001)
Time Spent: 0.5h (was: 20m)
> Ensure GobblinTaskRunner works when used without Yarn
> -----------------------------------------------------
>
> Key: GOBBLIN-1743
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1743
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> this PR [https://github.com/apache/gobblin/pull/3519/files] has a call to
> Helix cluster contained outside of a conditional that was previously never
> encountered for Fliptop use case. I moved the call back inside the
> conditional to ensure we don't attempt to retrieve an instanceConfig that is
> not registered with Helix as we don't have Yarn mode enabled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
