meethngala commented on code in PR #3616:
URL: https://github.com/apache/gobblin/pull/3616#discussion_r1095291874
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriter.java:
##########
@@ -495,20 +512,32 @@ private void ensureDirectoryExists(FileSystem fs, Path
path, Iterator<OwnerAndPe
if (ownerAndPermission.getFsPermission() != null) {
log.debug("Applying permissions {} to path {}.",
ownerAndPermission.getFsPermission(), path);
+ if (ownerAndPermission.getStickyBit() != null) {
+ FsPermission fsPermissionWithStickyBit =
getFsPermissionWithStickyBit(ownerAndPermission);
+ ownerAndPermission.setFsPermission(fsPermissionWithStickyBit);
+ }
fs.setPermission(path,
addExecutePermissionToOwner(ownerAndPermission.getFsPermission()));
}
String group = ownerAndPermission.getGroup();
String owner = ownerAndPermission.getOwner();
+ List<AclEntry> aclEntries = ownerAndPermission.getAclEntries();
if (group != null || owner != null) {
log.debug("Applying owner {} and group {} to path {}.", owner, group,
path);
fs.setOwner(path, owner, group);
}
+ if (!aclEntries.isEmpty()) {
+ setAclOnPath(fs, path, aclEntries);
Review Comment:
latest commit doesn't require this abstraction... since the only reason we
had this stubbing was to make unit testing easier. But now, after the latest
changes I directly call setAcl and override the localFs in the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
