meethngala commented on code in PR #3616:
URL: https://github.com/apache/gobblin/pull/3616#discussion_r1097760828
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriterTest.java:
##########
@@ -402,8 +423,29 @@ public void testCommit() throws IOException {
// previously existing paths should not have permissions changed
fileStatus = this.fs.getFileStatus(existingOutputPath);
Assert.assertEquals(fileStatus.getPermission(), existingPathPermission);
-
+ verifyAclEntries(writer, pathToAclEntries, expectedOutputPath);
Assert.assertFalse(this.fs.exists(writer.stagingDir));
+
+ }
+
+ private void verifyAclEntries(FileAwareInputStreamDataWriter writer,
ConcurrentHashMap pathToAclEntries, Path expectedOutputPath) {
+ // fetching and preparing file paths from FileAwareInputStreamDataWriter
object
+ Path stagingDir = writer.stagingDir;
Review Comment:
yes, we don't have to. I have updated my PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
