ZihanLi58 opened a new pull request, #3636: URL: https://github.com/apache/gobblin/pull/3636
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1773 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): We used to check the quota when we accept flow for ad-hoc flow and run immediately flow. But we only use the same execution id for ad-hoc flow. So for a run immediately flow, we will check quota once with a random execution id, and then really run the job with a different execution id and forget the first one. This will cause us to double-check the quota for a run immediately flow and never release one of them. In this PR: 1. We change the behavior to only check the quota upon accepting the request when it's an adhoc job, and for run-immediate flow, we won't check the quota. If quota exceeds, we will fail the first job but still keep the config and schedule the job in the future 2. When we see there is duplicate flow running and skip the exception, if it is an adhoc flow, we will release the quota for corresponding execution. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Unit tests ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 3. Subject is limited to 50 characters 4. Subject does not end with a period 5. Subject uses the imperative mood ("add", not "adding") 6. Body wraps at 72 characters 7. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
