Will-Lo commented on code in PR #3636:
URL: https://github.com/apache/gobblin/pull/3636#discussion_r1100689643
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/dag_action_store/MysqlDagActionStore.java:
##########
@@ -67,7 +68,8 @@ public MysqlDagActionStore(Config config) throws IOException {
this.tableName = ConfigUtils.getString(config,
ConfigurationKeys.STATE_STORE_DB_TABLE_KEY,
ConfigurationKeys.DEFAULT_STATE_STORE_DB_TABLE);
- this.dataSource = MysqlStateStore.newDataSource(config);
Review Comment:
If we deem this function not safe to use as it does not read from the shared
threadpool, would it be appropriate to make MySqlStateStore.newDataSource
package private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
