[
https://issues.apache.org/jira/browse/GOBBLIN-1781?focusedWorklogId=844197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844197
]
ASF GitHub Bot logged work on GOBBLIN-1781:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/23 23:35
Start Date: 07/Feb/23 23:35
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3638:
URL: https://github.com/apache/gobblin/pull/3638#discussion_r1099412670
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java:
##########
@@ -208,6 +208,9 @@ public class YarnService extends AbstractIdleService {
private volatile boolean shutdownInProgress = false;
+ @VisibleForTesting
+ protected volatile boolean startupInProgress = true;
Review Comment:
Is this protected because startup is also protected?
Issue Time Tracking
-------------------
Worklog Id: (was: 844197)
Time Spent: 0.5h (was: 20m)
> Helix offline instance purging is not thread safe in the yarn service
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1781
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1781
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Helix instances are purged during startup of the yarn service. This operation
> must be done without new helix instances being added or removed (i.e. the API
> call is not thread safe).
>
> The current implementation blocks the yarn service from allocating initial
> containers while the helix instance purging is enabled, but it does not
> prevent other external services from requesting containers through its public
> methods.
> These 2 services start up concurrently, and it's possible that the
> AutoScalingYarnManager starts up before the Yarn Service is completely
> finished purging. This means leads to the AutoScalingYarnManager to
> requestContainers while the instances are still purging.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
