[
https://issues.apache.org/jira/browse/GOBBLIN-1781?focusedWorklogId=844203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844203
]
ASF GitHub Bot logged work on GOBBLIN-1781:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/23 00:21
Start Date: 08/Feb/23 00:21
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3638:
URL: https://github.com/apache/gobblin/pull/3638#issuecomment-1421690291
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3638](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(32242fc) into
[master](https://codecov.io/gh/apache/gobblin/commit/69f3f9c33c9679d723c447fbe626db8f1b7afa9e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(69f3f9c) will **increase** coverage by `3.48%`.
> The diff coverage is `16.66%`.
```diff
@@ Coverage Diff @@
## master #3638 +/- ##
============================================
+ Coverage 46.58% 50.07% +3.48%
+ Complexity 10672 5766 -4906
============================================
Files 2133 1065 -1068
Lines 83557 40499 -43058
Branches 9290 4541 -4749
============================================
- Hits 38928 20278 -18650
+ Misses 41068 18466 -22602
+ Partials 3561 1755 -1806
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `15.08% <16.66%> (+0.05%)` | :arrow_up: |
|
[...a/management/copy/publisher/CopyDataPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcHVibGlzaGVyL0NvcHlEYXRhUHVibGlzaGVyLmphdmE=)
| `72.25% <0.00%> (-1.30%)` | :arrow_down: |
|
[...anagement/copy/replication/ConfigBasedDataset.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWREYXRhc2V0LmphdmE=)
| `68.87% <0.00%> (ø)` | |
|
[...apache/gobblin/service/modules/flow/FlowUtils.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93L0Zsb3dVdGlscy5qYXZh)
| | |
|
[...a/org/apache/gobblin/util/http/HttpLimiterKey.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvaHR0cC9IdHRwTGltaXRlcktleS5qYXZh)
| | |
|
[...ain/java/org/apache/gobblin/writer/JdbcWriter.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9KZGJjV3JpdGVyLmphdmE=)
| | |
|
[.../org/apache/gobblin/metastore/MetaStoreModule.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL01ldGFTdG9yZU1vZHVsZS5qYXZh)
| | |
|
[...he/gobblin/config/common/impl/ImportTraverser.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9jb21tb24vaW1wbC9JbXBvcnRUcmF2ZXJzZXIuamF2YQ==)
| | |
|
[.../metrics/kafka/KafkaAvroEventKeyValueReporter.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FBdnJvRXZlbnRLZXlWYWx1ZVJlcG9ydGVyLmphdmE=)
| | |
|
[...rvice/modules/flowgraph/pathfinder/PathFinder.java](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9QYXRoRmluZGVyLmphdmE=)
| | |
| ... and [1063
more](https://codecov.io/gh/apache/gobblin/pull/3638?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 844203)
Time Spent: 1h 10m (was: 1h)
> Helix offline instance purging is not thread safe in the yarn service
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1781
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1781
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Helix instances are purged during startup of the yarn service. This operation
> must be done without new helix instances being added or removed (i.e. the API
> call is not thread safe).
>
> The current implementation blocks the yarn service from allocating initial
> containers while the helix instance purging is enabled, but it does not
> prevent other external services from requesting containers through its public
> methods.
> These 2 services start up concurrently, and it's possible that the
> AutoScalingYarnManager starts up before the Yarn Service is completely
> finished purging. This means leads to the AutoScalingYarnManager to
> requestContainers while the instances are still purging.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
