[
https://issues.apache.org/jira/browse/GOBBLIN-1773?focusedWorklogId=844464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844464
]
ASF GitHub Bot logged work on GOBBLIN-1773:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/23 21:19
Start Date: 08/Feb/23 21:19
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3636:
URL: https://github.com/apache/gobblin/pull/3636#discussion_r1100689643
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/dag_action_store/MysqlDagActionStore.java:
##########
@@ -67,7 +68,8 @@ public MysqlDagActionStore(Config config) throws IOException {
this.tableName = ConfigUtils.getString(config,
ConfigurationKeys.STATE_STORE_DB_TABLE_KEY,
ConfigurationKeys.DEFAULT_STATE_STORE_DB_TABLE);
- this.dataSource = MysqlStateStore.newDataSource(config);
Review Comment:
If we deem this function not safe to use as it does not read from the shared
threadpool, would it be appropriate to make MySqlStateStore.newDataSource
package private?
Issue Time Tracking
-------------------
Worklog Id: (was: 844464)
Time Spent: 0.5h (was: 20m)
> Fix bug in quota manager of gobblinservice
> ------------------------------------------
>
> Key: GOBBLIN-1773
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1773
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We used to check the quota when we accept flow for ad-hoc flow and run
> immediately flow. But we only use the same execution id for ad-hoc flow. So
> for a run immediately flow, we will check quota once with a random execution
> id, and then really run the job with a different execution id and forget the
> first one. This will cause us to double-check the quota for a run immediately
> flow and never release one of them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
