[
https://issues.apache.org/jira/browse/GOBBLIN-1773?focusedWorklogId=844618&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844618
]
ASF GitHub Bot logged work on GOBBLIN-1773:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/23 16:58
Start Date: 09/Feb/23 16:58
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3636:
URL: https://github.com/apache/gobblin/pull/3636#discussion_r1101767387
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -247,6 +253,13 @@ public void orchestrate(Spec spec) throws Exception {
+ "concurrent executions are disabled for this flow.", flowGroup,
flowName);
conditionallyUpdateFlowGaugeSpecState(spec, CompiledState.SKIPPED);
Instrumented.markMeter(this.skippedFlowsMeter);
+ if
(!((FlowSpec)spec).getConfigAsProperties().containsKey(ConfigurationKeys.JOB_SCHEDULE_KEY))
{
Review Comment:
This can come in a later PR but we should have a static function to check if
a FlowSpec is adhoc or not in the FlowSpec class
Issue Time Tracking
-------------------
Worklog Id: (was: 844618)
Time Spent: 1h (was: 50m)
> Fix bug in quota manager of gobblinservice
> ------------------------------------------
>
> Key: GOBBLIN-1773
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1773
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We used to check the quota when we accept flow for ad-hoc flow and run
> immediately flow. But we only use the same execution id for ad-hoc flow. So
> for a run immediately flow, we will check quota once with a random execution
> id, and then really run the job with a different execution id and forget the
> first one. This will cause us to double-check the quota for a run immediately
> flow and never release one of them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
