[
https://issues.apache.org/jira/browse/GOBBLIN-1784?focusedWorklogId=844605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844605
]
ASF GitHub Bot logged work on GOBBLIN-1784:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/23 16:02
Start Date: 09/Feb/23 16:02
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3641:
URL: https://github.com/apache/gobblin/pull/3641
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1784
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Currently, the DagManager will poll a dag until it receives that the *job*
has been completed/failed/cancelled, and then emit the flow event and clean up
the dag. However, on service restart or crash, it is possible that the flow
event never gets emitted. Since the dag is already cleaned up, this job status
becomes stuck, and will never progress.
To address this scenario, this PR only cleans up dags when the cleanup
function polls that the *flow status* is completed. If it does not receive the
flow status that the job is completed within 3 minutes of the dag finishing all
of its jobs, then it will re-emit the flow event in case it was lost.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- Modified existing tests to the DagManagerTest class to ensure that the
cleanup is working as expected on flow events
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 844605)
Remaining Estimate: 0h
Time Spent: 10m
> Race condition where on service restart DagManager will lose track of dags
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1784
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1784
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Gobblin-as-a-Service has a bug where on restart, the DagManager will clean up
> dags but a flow event is never sent.
> This leads to a scenario where if the event is never sent by the underlying
> notification system, the dag will already be cleaned up and thus the job
> status will permanently be stuck in a running state.
> The DagManager thus should only clean up its own reference of dags after it
> reads that the jobstatus monitor has properly saved the final flow status,
> and if a status hasn't been received by some timestamp (e.g. 5 mins), then
> the DagManager will re-emit the event in case it was lost.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
