[
https://issues.apache.org/jira/browse/GOBBLIN-1784?focusedWorklogId=844619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844619
]
ASF GitHub Bot logged work on GOBBLIN-1784:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/23 17:07
Start Date: 09/Feb/23 17:07
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3641:
URL: https://github.com/apache/gobblin/pull/3641#issuecomment-1424526964
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3641](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(92f3be1) into
[master](https://codecov.io/gh/apache/gobblin/commit/13faea46bd2f23999fb1bf9ea579296fb86d1e3d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(13faea4) will **decrease** coverage by `2.78%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3641 +/- ##
============================================
- Coverage 46.58% 43.80% -2.78%
+ Complexity 10681 2063 -8618
============================================
Files 2133 409 -1724
Lines 83573 17639 -65934
Branches 9295 2152 -7143
============================================
- Hits 38931 7727 -31204
+ Misses 41076 9053 -32023
+ Partials 3566 859 -2707
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[.../apache/gobblin/service/modules/flowgraph/Dag.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvRGFnLmphdmE=)
| | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| | |
|
[...rvice/modules/orchestration/DagManagerMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJNZXRyaWNzLmphdmE=)
| | |
|
[...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh)
| | |
|
[...pache/gobblin/data/management/copy/CopyEntity.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvQ29weUVudGl0eS5qYXZh)
| | |
|
[.../extractor/filebased/FileBasedHelperException.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZmlsZWJhc2VkL0ZpbGVCYXNlZEhlbHBlckV4Y2VwdGlvbi5qYXZh)
| | |
|
[...in/converter/avro/AvroToAvroCopyableConverter.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0F2cm9Ub0F2cm9Db3B5YWJsZUNvbnZlcnRlci5qYXZh)
| | |
|
[...gobblin/source/RegexPartitionedAvroFileSource.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9SZWdleFBhcnRpdGlvbmVkQXZyb0ZpbGVTb3VyY2UuamF2YQ==)
| | |
|
[...obblin/metrics/influxdb/InfluxDBEventReporter.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tbWV0cmljcy1pbmZsdXhkYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9tZXRyaWNzL2luZmx1eGRiL0luZmx1eERCRXZlbnRSZXBvcnRlci5qYXZh)
| | |
|
[...urce/extractor/filebased/SingleFileDownloader.java](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZmlsZWJhc2VkL1NpbmdsZUZpbGVEb3dubG9hZGVyLmphdmE=)
| | |
| ... and [1716
more](https://codecov.io/gh/apache/gobblin/pull/3641?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 844619)
Time Spent: 20m (was: 10m)
> Race condition where on service restart DagManager will lose track of dags
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1784
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1784
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Gobblin-as-a-Service has a bug where on restart, the DagManager will clean up
> dags but a flow event is never sent.
> This leads to a scenario where if the event is never sent by the underlying
> notification system, the dag will already be cleaned up and thus the job
> status will permanently be stuck in a running state.
> The DagManager thus should only clean up its own reference of dags after it
> reads that the jobstatus monitor has properly saved the final flow status,
> and if a status hasn't been received by some timestamp (e.g. 5 mins), then
> the DagManager will re-emit the event in case it was lost.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
