phet commented on code in PR #3664:
URL: https://github.com/apache/gobblin/pull/3664#discussion_r1149534093
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigV2ResourceLocalHandler.java:
##########
@@ -154,6 +154,53 @@ private String getErrorMessage(FlowSpec flowSpec) {
}
return "Could not form JSON in FlowConfigV2ResourceLocalHandler";
}
+
+ /**
+ * Update flowConfig locally and trigger all listeners iff @param
triggerListener is set to true
+ */
+ @Override
+ public UpdateResponse updateFlowConfig(FlowId flowId, FlowConfig flowConfig,
boolean triggerListener, long modifiedWatermark) {
Review Comment:
FYI, based on additional offline convo we had, I took a stab at combining
the change into the v1 endpoint handler -
https://github.com/apache/gobblin/pull/3665
unless there's an active reason to preserve this (surprising/incorrect)
behavior in v1, I prefer that approach, as it reduces code duplication while
also bringing correctness more widely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
