[
https://issues.apache.org/jira/browse/GOBBLIN-1804?focusedWorklogId=852888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-852888
]
ASF GitHub Bot logged work on GOBBLIN-1804:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/23 18:06
Start Date: 24/Mar/23 18:06
Worklog Time Spent: 10m
Work Description: phet opened a new pull request, #3664:
URL: https://github.com/apache/gobblin/pull/3664
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1804
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Reject flow config updates that would fail compilation by returning service
error
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added tests cases (also for "create flow", which was previously correct, but
untested)
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 852888)
Remaining Estimate: 0h
Time Spent: 10m
> FlowConfigV2 should reject updates that fail compilation and return service
> error code
> --------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1804
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1804
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-restli
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Users can create a working flow configuration, but when the config fails
> compilation it is rejected.
> Relatedly, when users try to update a working flow configuration with one
> that fails compilation, the update returns success, despite internal logging
> recording:
> "Ignoring the spec gobblin-flow:/testGroup/testName/. isExplain: false,
> compileSuccess: false, master: true".
> A subsequent GET request for that flow config shows the update didn't
> actually happen. thus the update's response was misleading and should be
> corrected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
