[
https://issues.apache.org/jira/browse/GOBBLIN-1809?focusedWorklogId=855983&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855983
]
ASF GitHub Bot logged work on GOBBLIN-1809:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/23 00:32
Start Date: 11/Apr/23 00:32
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3670:
URL: https://github.com/apache/gobblin/pull/3670
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1809
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Add new version finder which does not actually list filepaths, and just
constructs all unique path names/versions for a given lookback time with a
given path partition pattern. This is useful for example with the iceberg
cleanable datasets, which if decoupled from data files, should not depend on
existence of the file path.
Also fixed a bug in `DatasetCleaner` which sometimes causes the job to fail
during shutdown and not print the actual issue with the job.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added unit test and tested in retention job
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 855983)
Remaining Estimate: 0h
Time Spent: 10m
> Add new lookback version finder for use with iceberg retention
> --------------------------------------------------------------
>
> Key: GOBBLIN-1809
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1809
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
