[
https://issues.apache.org/jira/browse/GOBBLIN-1809?focusedWorklogId=856247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856247
]
ASF GitHub Bot logged work on GOBBLIN-1809:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/23 20:42
Start Date: 11/Apr/23 20:42
Worklog Time Spent: 10m
Work Description: jack-moseley commented on code in PR #3670:
URL: https://github.com/apache/gobblin/pull/3670#discussion_r1163308997
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/DatasetCleaner.java:
##########
@@ -176,7 +176,7 @@ public void onSuccess(Void arg0) {
@Override
public void close() throws IOException {
try {
- if (this.finishCleanSignal.isPresent()) {
+ if (this.finishCleanSignal != null &&
this.finishCleanSignal.isPresent()) {
Review Comment:
Yes I found that if an exception is thrown during setup (e.g. issue
instantiating the datasetsFinder), this will still be null which will cause the
job to fail without actually logging the exception.
Issue Time Tracking
-------------------
Worklog Id: (was: 856247)
Time Spent: 1h 10m (was: 1h)
> Add new lookback version finder for use with iceberg retention
> --------------------------------------------------------------
>
> Key: GOBBLIN-1809
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1809
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
