[ 
https://issues.apache.org/jira/browse/GOBBLIN-1808?focusedWorklogId=856172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856172
 ]

ASF GitHub Bot logged work on GOBBLIN-1808:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/23 16:24
            Start Date: 11/Apr/23 16:24
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1163062159


##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
     "commonsPool": "org.apache.commons:commons-pool2:2.4.2",
     "datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
     "datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+    "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",

Review Comment:
   I saw that, but wouldn't there also be a new `import` in java code?  ...or 
are classes already imported under a package that stays fixed, but the package 
now comes from a separate jar than it used to?
   
   overall, I'm still unclear (from reading only the code under PR) why this 
dep is needed?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 856172)
    Time Spent: 1h  (was: 50m)

> Bump Guava to version 20.0.0
> ----------------------------
>
>                 Key: GOBBLIN-1808
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1808
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-core
>    Affects Versions: 0.16.0
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>             Fix For: 0.16.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Gobblin depends on an ancient version of Guava, 15.0.0.
> This version of Guava was released in 2013 and is running into compatibility 
> issues with many modern dependencies.
> We should gradually work on upgrading Guava to a recent version, but for now 
> will try version 20.0.0 (released Oct 2016 which is still old) but the main 
> concern for large version bumps is to avoid compatibility issues with other 
> old Gobblin dependencies (Hive/Hadoop)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to