[
https://issues.apache.org/jira/browse/GOBBLIN-1808?focusedWorklogId=856508&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856508
]
ASF GitHub Bot logged work on GOBBLIN-1808:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/23 17:34
Start Date: 12/Apr/23 17:34
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3669:
URL: https://github.com/apache/gobblin/pull/3669#discussion_r1164446591
##########
gradle/scripts/dependencyDefinitions.gradle:
##########
@@ -49,8 +49,9 @@ ext.externalDependency = [
"commonsPool": "org.apache.commons:commons-pool2:2.4.2",
"datanucleusCore": "org.datanucleus:datanucleus-core:3.2.10",
"datanucleusRdbms": "org.datanucleus:datanucleus-rdbms:3.2.9",
+ "errorProne": "com.google.errorprone:error_prone_annotations:2.0.15",
Review Comment:
yes, I see... makes sense there would be no `import`s needed in the case of
one of our direct deps having left out their own dependency so it falls instead
upon us to specify for them. clearly preferable when transitive dependency
resolution automates the solution... but now that we know what's missing, not
too hard for us to add manually.
Issue Time Tracking
-------------------
Worklog Id: (was: 856508)
Time Spent: 1.5h (was: 1h 20m)
> Bump Guava to version 20.0.0
> ----------------------------
>
> Key: GOBBLIN-1808
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1808
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Gobblin depends on an ancient version of Guava, 15.0.0.
> This version of Guava was released in 2013 and is running into compatibility
> issues with many modern dependencies.
> We should gradually work on upgrading Guava to a recent version, but for now
> will try version 20.0.0 (released Oct 2016 which is still old) but the main
> concern for large version bumps is to avoid compatibility issues with other
> old Gobblin dependencies (Hive/Hadoop)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
