[
https://issues.apache.org/jira/browse/GOBBLIN-1829?focusedWorklogId=860196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860196
]
ASF GitHub Bot logged work on GOBBLIN-1829:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/23 23:16
Start Date: 02/May/23 23:16
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3691:
URL: https://github.com/apache/gobblin/pull/3691#discussion_r1183127348
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaAvroJobStatusMonitor.java:
##########
@@ -127,13 +127,14 @@ public org.apache.gobblin.configuration.State
parseJobStatus(GobblinTrackingEven
case TimingEvent.FlowTimings.FLOW_COMPILED:
properties.put(JobStatusRetriever.EVENT_NAME_FIELD,
ExecutionStatus.COMPILED.name());
break;
- case TimingEvent.LauncherTimings.WORK_UNITS_PREPARATION:
+ case TimingEvent.LauncherTimings.WORK_UNITS_CREATION:
properties.put(TimingEvent.WORKUNIT_PLAN_START_TIME,
properties.getProperty(TimingEvent.METADATA_START_TIME));
properties.put(TimingEvent.WORKUNIT_PLAN_END_TIME,
properties.getProperty(TimingEvent.METADATA_END_TIME));
break;
case TimingEvent.LauncherTimings.JOB_START:
case TimingEvent.FlowTimings.FLOW_RUNNING:
case TimingEvent.LauncherTimings.JOB_SUMMARY:
+ case TimingEvent.LauncherTimings.WORK_UNITS_PREPARATION:
Review Comment:
Why do we need this to set job status as running?
Issue Time Tracking
-------------------
Worklog Id: (was: 860196)
Time Spent: 20m (was: 10m)
> GaaSObservabilityEvent tracks Workunit preparation timer instead of Workunit
> creation timer
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1829
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1829
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In Gobblin framework, there are 2 events that look similar but do very
> different functions:
> 1. WorkUnitPreparationTimer - which serializes workunits and compacts them
> into MultiWorkUnits
> 2. WorkUnitCreationTimer - which tracks the time taken to discover the work
> needed for Gobblin to launch a job.
> We want to track #2 in metrics rather than #1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
