[
https://issues.apache.org/jira/browse/GOBBLIN-1829?focusedWorklogId=860197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860197
]
ASF GitHub Bot logged work on GOBBLIN-1829:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/23 23:27
Start Date: 02/May/23 23:27
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3691:
URL: https://github.com/apache/gobblin/pull/3691#issuecomment-1532275357
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3691](https://app.codecov.io/gh/apache/gobblin/pull/3691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(729352a) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/e47aef7f8eeba3b6d52901cab299048a467eaf24?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e47aef7) will **increase** coverage by `1.62%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3691 +/- ##
============================================
+ Coverage 46.99% 48.62% +1.62%
+ Complexity 10788 7925 -2863
============================================
Files 2138 1478 -660
Lines 84040 58429 -25611
Branches 9340 6716 -2624
============================================
- Hits 39497 28412 -11085
+ Misses 40955 27395 -13560
+ Partials 3588 2622 -966
```
[see 667 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3691/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 860197)
Time Spent: 0.5h (was: 20m)
> GaaSObservabilityEvent tracks Workunit preparation timer instead of Workunit
> creation timer
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1829
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1829
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In Gobblin framework, there are 2 events that look similar but do very
> different functions:
> 1. WorkUnitPreparationTimer - which serializes workunits and compacts them
> into MultiWorkUnits
> 2. WorkUnitCreationTimer - which tracks the time taken to discover the work
> needed for Gobblin to launch a job.
> We want to track #2 in metrics rather than #1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
