[
https://issues.apache.org/jira/browse/GOBBLIN-1832?focusedWorklogId=861273&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861273
]
ASF GitHub Bot logged work on GOBBLIN-1832:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/23 01:47
Start Date: 10/May/23 01:47
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3695:
URL: https://github.com/apache/gobblin/pull/3695
…Hive Table Views
We should not allow hive retention on a view since it shouldn't have access
to delete underlying data. Instead it should throw a warning message if it is a
view instead of failing the job as there may be retention jobs configured to
include both hive tables and views. We want to be able to dynamically determine
at runtime whether or not to skip retention on the dataset in question rather
than statically allow/denylist tables in the configurations.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1832
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
We should not allow hive retention on a view since it shouldn't have access
to delete underlying data. Instead it should throw a warning message if it is a
view instead of failing the job as there may be retention jobs configured to
include both hive tables and views. We want to be able to dynamically determine
at runtime whether or not to skip retention on the dataset in question rather
than statically allow/denylist tables in the configurations.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 861273)
Remaining Estimate: 0h
Time Spent: 10m
> Skip attempting retention of Hive Table Views
> ----------------------------------------------
>
> Key: GOBBLIN-1832
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1832
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should not allow hive retention on a view since it shouldn't have access
> to delete underlying data. Instead it should throw a warning message if it is
> a view instead of failing the job as there may be retention jobs configured
> to include both hive tables and views. We want to be able to dynamically
> determine at runtime whether or not to skip retention on the dataset in
> question rather than statically allow/denylist tables in the configurations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
