[
https://issues.apache.org/jira/browse/GOBBLIN-1832?focusedWorklogId=861274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861274
]
ASF GitHub Bot logged work on GOBBLIN-1832:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/23 01:48
Start Date: 10/May/23 01:48
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3695:
URL: https://github.com/apache/gobblin/pull/3695#discussion_r1189276199
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/version/finder/AbstractHiveDatasetVersionFinder.java:
##########
@@ -56,8 +58,9 @@ public Class<? extends DatasetVersion> versionClass() {
* Calls {@link #getDatasetVersion(Partition)} for every {@link Partition}
found.
* <p>
* Note: If an exception occurs while processing a partition, that partition
will be ignored in the returned collection
+ * Also note that if the dataset passed is a view type, we will return an
empty list even if the underlying table is
+ * partitioned.
* </p>
- *
Review Comment:
i'll remove this
Issue Time Tracking
-------------------
Worklog Id: (was: 861274)
Time Spent: 20m (was: 10m)
> Skip attempting retention of Hive Table Views
> ----------------------------------------------
>
> Key: GOBBLIN-1832
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1832
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should not allow hive retention on a view since it shouldn't have access
> to delete underlying data. Instead it should throw a warning message if it is
> a view instead of failing the job as there may be retention jobs configured
> to include both hive tables and views. We want to be able to dynamically
> determine at runtime whether or not to skip retention on the dataset in
> question rather than statically allow/denylist tables in the configurations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
