meethngala commented on code in PR #3697:
URL: https://github.com/apache/gobblin/pull/3697#discussion_r1204560585
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/Utils/IcebergUtils.java:
##########
@@ -248,6 +248,7 @@ public static DataFile
getIcebergDataFileWithMetric(org.apache.gobblin.metadata.
IcebergUtils.getMapFromIntegerLongPairs(file.getFileMetrics().getColumnSizes(),
schemaIdMap),
IcebergUtils.getMapFromIntegerLongPairs(file.getFileMetrics().getValueCounts(),
schemaIdMap),
IcebergUtils.getMapFromIntegerLongPairs(file.getFileMetrics().getNullValueCounts(),
schemaIdMap),
+ IcebergUtils.getMapFromIntegerLongPairs(Lists.newArrayList(),
schemaIdMap), // metric value will be null since Nan values are supported from
avro version 1.10.*
Review Comment:
I have added a TODO comment in case we need to handle the file metric
conversion for ORC in my latest commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
