meethngala commented on code in PR #3697:
URL: https://github.com/apache/gobblin/pull/3697#discussion_r1228717988
##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/HiveMetadataWriterTest.java:
##########
@@ -128,7 +128,6 @@ public void clean() throws Exception {
@BeforeSuite
public void setUp() throws Exception {
Class.forName("org.apache.derby.jdbc.EmbeddedDriver").newInstance();
- startMetastore();
Review Comment:
the local Metastore is now started by the parent class: `HiveMetastoreTest`
with the upgrade, since they now added `@BeforeClass` annotation for
`startMetastore()`. Here's the [Junit api
doc](https://junit.org/junit4/javadoc/latest/org/junit/BeforeClass.html) for
the same. Thus, we do not need to start again for our unit tests otherwise we
would run into this issue:`AlreadyExistsException(message:Database hivedb
already exists)`. Alternative would be to try starting again on our side and
catch the above exception and handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
