[
https://issues.apache.org/jira/browse/GOBBLIN-1836?focusedWorklogId=862389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862389
]
ASF GitHub Bot logged work on GOBBLIN-1836:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/23 00:11
Start Date: 26/May/23 00:11
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3699:
URL: https://github.com/apache/gobblin/pull/3699#issuecomment-1563652646
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3699?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3699](https://app.codecov.io/gh/apache/gobblin/pull/3699?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(a9d226b) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/158d6fff546ee28ad7b542bfe78e5263af8843c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(158d6ff) will **decrease** coverage by `4.66%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3699 +/- ##
============================================
- Coverage 49.45% 44.80% -4.66%
+ Complexity 9309 2096 -7213
============================================
Files 1756 411 -1345
Lines 68468 17734 -50734
Branches 7809 2162 -5647
============================================
- Hits 33862 7945 -25917
+ Misses 31466 8932 -22534
+ Partials 3140 857 -2283
```
| [Impacted
Files](https://app.codecov.io/gh/apache/gobblin/pull/3699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://app.codecov.io/gh/apache/gobblin/pull/3699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `68.68% <100.00%> (+2.02%)` | :arrow_up: |
|
[.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://app.codecov.io/gh/apache/gobblin/pull/3699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh)
| `72.41% <100.00%> (+0.04%)` | :arrow_up: |
... and [1348 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3699/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 862389)
Time Spent: 20m (was: 10m)
> Ensuring Task Reliability: Handling Job Cancellation and Graceful Exits for
> Error-Free Completion
> -------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1836
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1836
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In our system, when a helix disconnection occurs, we take the necessary step
> to cancel the ongoing job. Furthermore, when we opt for a graceful exit, we
> ensure that no exception is thew and we mark the task as complete. However,
> it is important to note that due to this graceful exit, the task cannot be
> retried accurately.
> So we need to introduce a cancel flag to make sure we return the correct task
> status
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
