[
https://issues.apache.org/jira/browse/GOBBLIN-1836?focusedWorklogId=862495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862495
]
ASF GitHub Bot logged work on GOBBLIN-1836:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/23 00:58
Start Date: 27/May/23 00:58
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3699:
URL: https://github.com/apache/gobblin/pull/3699#discussion_r1207532670
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java:
##########
@@ -219,6 +228,7 @@ public void cancel() {
log.info("Gobblin helix task cancellation invoked for jobId {}.", jobId);
if (this.task != null ) {
try {
+ this.isCanceled = true;
Review Comment:
in some part of gobblin code, we separated these two cases by making two
different boolean flags, `cancellationRequested` and `cancelled`
Issue Time Tracking
-------------------
Worklog Id: (was: 862495)
Time Spent: 1h (was: 50m)
> Ensuring Task Reliability: Handling Job Cancellation and Graceful Exits for
> Error-Free Completion
> -------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1836
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1836
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In our system, when a helix disconnection occurs, we take the necessary step
> to cancel the ongoing job. Furthermore, when we opt for a graceful exit, we
> ensure that no exception is thew and we mark the task as complete. However,
> it is important to note that due to this graceful exit, the task cannot be
> retried accurately.
> So we need to introduce a cancel flag to make sure we return the correct task
> status
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
