Peiyingy opened a new pull request, #3704: URL: https://github.com/apache/gobblin/pull/3704
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1840] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1840 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): #### Problem Statement Currently, there is a problem with the Helix replanner, that Azkaban jobs can be triggered at the same time, causing replanning to happen in a short time span twice or more. It is expensive to create a replanner, consuming a lot of resources and a long time for both the Zookeeper and the Application Master. #### Solution We implemented a concurrent hashmap to store the create time for each job so that we can check the hashmap record to make sure that we only reschedule the workflow when the last replanning is earlier than the throttle timeout threshold, which has a default time of an hour and totally configurable. We also have a throttling feature that is able to turn off, stopping this early return mechanism. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: <img width="333" alt="Screenshot 2023-06-14 at 11 00 50 AM" src="https://github.com/apache/gobblin/assets/112960226/098448b9-ee6d-4f7f-9672-d51ad7f62b48";> The unit tests are permutations regards to three variables: same or different workflow, time span, and whether throttling is enabled. The original testNewJobAndUpdate is for the same workflow, long time period, and throttle enabled. The rest of the tests have descriptive names. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
