umustafi commented on code in PR #3704: URL: https://github.com/apache/gobblin/pull/3704#discussion_r1231361824
########## gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java: ########## @@ -110,6 +113,8 @@ public class GobblinHelixJobScheduler extends JobScheduler implements StandardMe private boolean startServicesCompleted; private final long helixJobStopTimeoutMillis; + private final Duration throttleTimeoutDuration; + private ConcurrentHashMap<String, Instant> jobStartTimeMap; Review Comment: I don't have that strong of a preference with Instant vs. Timestamp/Long, the latter are more common on GaaS side so I was initially surprised. More important to update the map name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
