[
https://issues.apache.org/jira/browse/GOBBLIN-1843?focusedWorklogId=865636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865636
]
ASF GitHub Bot logged work on GOBBLIN-1843:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/23 22:15
Start Date: 14/Jun/23 22:15
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3705:
URL: https://github.com/apache/gobblin/pull/3705#discussion_r1230227463
##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/predicates/DatasetHiveSchemaContainsNonOptionalUnion.java:
##########
@@ -76,7 +76,10 @@ private DbAndTable getDbAndTable(T dataset) {
throw new IllegalStateException(String.format("Dataset urn [%s] doesn't
follow expected pattern. " +
"Expected pattern = %s", dataset.getUrn(), pattern.pattern()));
}
- return new DbAndTable(m.group(1), m.group(2));
+
+ // hive does not use '-' in the table name, so they are replaced with '_'
+ String hiveTableName = m.group(2).replaceAll("-", "_");
Review Comment:
Let's create a new method and use it here and in HiveTable.java line 45
Issue Time Tracking
-------------------
Worklog Id: (was: 865636)
Time Spent: 0.5h (was: 20m)
> Utility for detecting non optional unions should convert dataset urn to hive
> compatible format
> ----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1843
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1843
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
