[
https://issues.apache.org/jira/browse/GOBBLIN-1843?focusedWorklogId=865828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865828
]
ASF GitHub Bot logged work on GOBBLIN-1843:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/23 17:09
Start Date: 15/Jun/23 17:09
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3705:
URL: https://github.com/apache/gobblin/pull/3705#issuecomment-1593443576
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3705](https://app.codecov.io/gh/apache/gobblin/pull/3705?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(4115837) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/fc508ca272cc2ea0a9f5cdd28e72f60ce3c7912b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(fc508ca) will **increase** coverage by `2.61%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #3705 +/- ##
============================================
+ Coverage 46.87% 49.48% +2.61%
+ Complexity 10771 9317 -1454
============================================
Files 2138 1756 -382
Lines 84139 68480 -15659
Branches 9357 7810 -1547
============================================
- Hits 39436 33885 -5551
+ Misses 41102 31455 -9647
+ Partials 3601 3140 -461
```
| [Impacted
Files](https://app.codecov.io/gh/apache/gobblin/pull/3705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[.../org/apache/gobblin/compaction/hive/HiveTable.java](https://app.codecov.io/gh/apache/gobblin/pull/3705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vaGl2ZS9IaXZlVGFibGUuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...che/gobblin/hive/metastore/HiveMetaStoreUtils.java](https://app.codecov.io/gh/apache/gobblin/pull/3705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlVXRpbHMuamF2YQ==)
| `56.27% <66.66%> (-0.05%)` | :arrow_down: |
|
[...ment/dataset/DatasetsFinderFilteringDecorator.java](https://app.codecov.io/gh/apache/gobblin/pull/3705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvRGF0YXNldHNGaW5kZXJGaWx0ZXJpbmdEZWNvcmF0b3IuamF2YQ==)
| `89.18% <100.00%> (+0.95%)` | :arrow_up: |
|
[...tes/DatasetHiveSchemaContainsNonOptionalUnion.java](https://app.codecov.io/gh/apache/gobblin/pull/3705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvcHJlZGljYXRlcy9EYXRhc2V0SGl2ZVNjaGVtYUNvbnRhaW5zTm9uT3B0aW9uYWxVbmlvbi5qYXZh)
| `70.83% <100.00%> (ø)` | |
... and [404 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3705/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 865828)
Time Spent: 50m (was: 40m)
> Utility for detecting non optional unions should convert dataset urn to hive
> compatible format
> ----------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1843
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1843
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
