umustafi commented on code in PR #3707:
URL: https://github.com/apache/gobblin/pull/3707#discussion_r1236207362
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -612,7 +613,10 @@ public void executeImpl(JobExecutionContext context)
long triggerTimestampMillis = trigger.getPreviousFireTime().getTime();
jobProps.setProperty(ConfigurationKeys.SCHEDULER_EVENT_TO_TRIGGER_TIMESTAMP_MILLIS_KEY,
String.valueOf(triggerTimestampMillis));
-
+ LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] -
triggerTime: {} nextTriggerTime: {} - "
+ + "Job triggered by scheduler",
Review Comment:
I'll update the first comment to say newly scheduled, but this second
instance is not re-scheduled but rather the callback invoked when the Scheduler
trigger fires and the job is actually run. This is the important part we want
to validate. However, I may need to override the super class method by the
`GobblinServiceJobScheduler` to retrieve the flow properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
