umustafi commented on code in PR #3707:
URL: https://github.com/apache/gobblin/pull/3707#discussion_r1237537547
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -398,7 +398,8 @@ public void scheduleJob(Properties jobProps, JobListener
jobListener, Map<String
// Schedule the Quartz job with a trigger built from the job
configuration
Trigger trigger = createTriggerForJob(job.getKey(), jobProps);
this.scheduler.getScheduler().scheduleJob(job, trigger);
- LOG.info(String.format("Scheduled job %s. Next run: %s.", job.getKey(),
trigger.getNextFireTime()));
+ LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] -
nextTriggerTime: {} - "
+ + "Job scheduled", job.getKey().getName(), job.getKey().getGroup(),
trigger.getNextFireTime());
Review Comment:
Good pt, there should be two different log lines printed for `JobScheduler`
and `GobblinServiceJobScheduler`. Both contain job name and group, but only the
latter will have the flow name and flow group. I created a util that will be
overridden by the `GobblinServiceJobScheduler` class to extract the flow
information for the tracing log line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
