[
https://issues.apache.org/jira/browse/GOBBLIN-1847?focusedWorklogId=867862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-867862
]
ASF GitHub Bot logged work on GOBBLIN-1847:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/23 20:43
Start Date: 27/Jun/23 20:43
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3711:
URL: https://github.com/apache/gobblin/pull/3711#discussion_r1244327913
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -462,10 +466,14 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
}
// TODO: Better error handling. The current impl swallows exceptions for
jobs that were started by this method call.
- // One potential way to improve the error handling is to make this error
swallowing conifgurable
+ // One potential way to improve the error handling is to make this error
swallowing configurable
} catch (Throwable t) {
errorInJobLaunching = t;
} finally {
+ if (isCancelWorkflowOnExitEnabled) {
+ cancelJob(jobListener);
Review Comment:
I'm not getting the idea to put this under the final block and add a flag to
determine the logic. Can we consider putting it under the catch block and check
the value of isLaunched to determine whether we need to cancel the job or not?
Issue Time Tracking
-------------------
Worklog Id: (was: 867862)
Time Spent: 40m (was: 0.5h)
> HelixException from the Job manager in Fast Ingest should try to delete the
> existing workflow
> ---------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1847
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1847
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
