[
https://issues.apache.org/jira/browse/GOBBLIN-1847?focusedWorklogId=867874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-867874
]
ASF GitHub Bot logged work on GOBBLIN-1847:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/23 21:23
Start Date: 27/Jun/23 21:23
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3711:
URL: https://github.com/apache/gobblin/pull/3711#discussion_r1244376380
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -462,10 +466,14 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
}
// TODO: Better error handling. The current impl swallows exceptions for
jobs that were started by this method call.
- // One potential way to improve the error handling is to make this error
swallowing conifgurable
+ // One potential way to improve the error handling is to make this error
swallowing configurable
} catch (Throwable t) {
errorInJobLaunching = t;
} finally {
+ if (isCancelWorkflowOnExitEnabled) {
+ cancelJob(jobListener);
Review Comment:
Your approach does work though. If we don't want a flag, and GaaS fliptop
also wants to cancel the workflow on error (I have a feeling this is not the
case though), then yes we can do your approach without a flag.
What do you think?
Issue Time Tracking
-------------------
Worklog Id: (was: 867874)
Time Spent: 1.5h (was: 1h 20m)
> HelixException from the Job manager in Fast Ingest should try to delete the
> existing workflow
> ---------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1847
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1847
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
