[
https://issues.apache.org/jira/browse/GOBBLIN-1865?focusedWorklogId=874293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874293
]
ASF GitHub Bot logged work on GOBBLIN-1865:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/23 20:06
Start Date: 02/Aug/23 20:06
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3729:
URL: https://github.com/apache/gobblin/pull/3729
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1865
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
With "gobblin.cluster.job.useGeneratedJobIds" configuration, jobs with that
prefix should be using the system timestamp of Gobblin cluster instead of a
provided flow execution ID.
Instead of this, it is more consistent to append flowExecutionId to a
jobName then append a timestamp on top of that, so that all earlystop jobs
relating to a flow execution can be tracked.
Now jobNames should have the following structure:
job_ActualJob<jobName><flowExecutionId><timestamp>
The timestamp is needed so that Helix can run concurrent jobs given a job ID.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 874293)
Remaining Estimate: 0h
Time Spent: 10m
> Fix bug where overriding job execution ids cause issue with earlystop jobs
> and job tracking
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1865
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1865
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Reporter: William Lo
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With "gobblin.cluster.job.useGeneratedJobIds" configuration, jobs with that
> prefix should be using the system timestamp of Gobblin cluster instead of a
> provided flow execution ID.
> Instead of this, it is more consistent to append flowExecutionId to a jobName
> then append a timestamp on top of that, so that all earlystop jobs relating
> to a flow execution can be tracked.
> Now jobNames should have the following structure:
> job_ActualJob<jobName>{_}<flowExecutionId>{_}<timestamp>
> The timestamp is needed so that Helix can run concurrent jobs given a job ID.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
