[
https://issues.apache.org/jira/browse/GOBBLIN-1865?focusedWorklogId=874294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-874294
]
ASF GitHub Bot logged work on GOBBLIN-1865:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/23 20:20
Start Date: 02/Aug/23 20:20
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3729:
URL: https://github.com/apache/gobblin/pull/3729#issuecomment-1662917372
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3729?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3729](https://app.codecov.io/gh/apache/gobblin/pull/3729?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(07592c1) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/183bc5c44550b8ca888d589e849c3fb7dad8e90f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(183bc5c) will **decrease** coverage by `1.66%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3729 +/- ##
============================================
- Coverage 46.99% 45.33% -1.66%
+ Complexity 10830 2138 -8692
============================================
Files 2144 413 -1731
Lines 84748 17956 -66792
Branches 9410 2184 -7226
============================================
- Hits 39824 8141 -31683
+ Misses 41297 8947 -32350
+ Partials 3627 868 -2759
```
| [Files
Changed](https://app.codecov.io/gh/apache/gobblin/pull/3729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/cluster/HelixJobsMapping.java](https://app.codecov.io/gh/apache/gobblin/pull/3729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhKb2JzTWFwcGluZy5qYXZh)
| `81.53% <100.00%> (ø)` | |
... and [1733 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3729/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 874294)
Time Spent: 20m (was: 10m)
> Fix bug where overriding job execution ids cause issue with earlystop jobs
> and job tracking
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1865
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1865
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Reporter: William Lo
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With "gobblin.cluster.job.useGeneratedJobIds" configuration, jobs with that
> prefix should be using the system timestamp of Gobblin cluster instead of a
> provided flow execution ID.
> Instead of this, it is more consistent to append flowExecutionId to a jobName
> then append a timestamp on top of that, so that all earlystop jobs relating
> to a flow execution can be tracked.
> Now jobNames should have the following structure:
> job_ActualJob<jobName>{_}<flowExecutionId>{_}<timestamp>
> The timestamp is needed so that Helix can run concurrent jobs given a job ID.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
