umustafi opened a new pull request, #3731: URL: https://github.com/apache/gobblin/pull/3731
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1868 ### Description - [X] Here are some details about my PR, including screenshots (if applicable): Create a Util class **`ExecutionChecksUtil`** to contain functionality re-used between the `DagManager` and `Orchestrator` when launching executions of a flow spec. In the common case, the `Orchestrator` receives a flow to orchestrate, performs necessary validations, and forwards the execution responsibility to the `DagManager`. The `DagManager's` responsibility is to carry out any flow action requests. However, with launch executions now being stored in the `DagActionStateStore`, on restart or leadership change the `DagManager` has to perform validations before executing any launch actions the previous leader was unable to complete. We tried to have the `DagManager` refer to the `Orchestrator` to avoid duplicating code in a previous commit, but introduced a circular dependency between the `DagManager` and `Orchestrator` and was unable to work in runtime. This class is utilized to store the common functionality. It is stateless and requires all stateful pieces to be passed as input from the caller. Note: We expect further refactoring to be done to the DagManager in later stage of multi-active development so we do not attempt major reorganization as abstractions may change. Also creates a class, `**SharedFlowMetricsContainer**` to store shared metrics between the `DagManager` and `Orchestrator`. ### Tests - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Deploys locally and service starts ### Commits - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
