phet commented on code in PR #3731: URL: https://github.com/apache/gobblin/pull/3731#discussion_r1284729295
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/SharedFlowMetricsContainer.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.utils; + +import com.codahale.metrics.Meter; +import com.codahale.metrics.MetricRegistry; +import com.google.common.base.Optional; +import com.google.common.collect.Maps; +import com.typesafe.config.Config; +import java.util.Map; +import javax.inject.Inject; +import javax.inject.Singleton; +import lombok.Data; +import lombok.Setter; +import org.apache.gobblin.configuration.ConfigurationKeys; +import org.apache.gobblin.instrumented.Instrumented; +import org.apache.gobblin.metrics.ContextAwareGauge; +import org.apache.gobblin.metrics.MetricContext; +import org.apache.gobblin.metrics.RootMetricContext; +import org.apache.gobblin.metrics.ServiceMetricNames; +import org.apache.gobblin.runtime.api.Spec; +import org.apache.gobblin.service.modules.orchestration.Orchestrator; +import org.apache.gobblin.util.ConfigUtils; + + +/** + * Class to store flow related metrics shared between the {@link Orchestrator} and {@link DagManager} so we can easily + * track all flow compilations and skipped flows handled between the two in a common place. + */ +@Singleton +@Data +public class SharedFlowMetricsContainer { + protected final MetricContext metricContext; + private Map<String, FlowCompiledState> flowGauges = Maps.newHashMap(); + private Optional<Meter> skippedFlowsMeter; + + @Inject + public SharedFlowMetricsContainer(Config config) { + this.metricContext = Instrumented.getMetricContext(ConfigUtils.configToState(config), SharedFlowMetricsContainer.class); + this.skippedFlowsMeter = Optional.of(metricContext.contextAwareMeter(ServiceMetricNames.SKIPPED_FLOWS)); + } + + /** + * Adds a new FlowGauge to the metric context if one does not already exist for this flow spec + */ + public void addFlowGauge(Spec spec, Config flowConfig, String flowName, String flowGroup) { Review Comment: I find widely-employed, non-semantic types like `String` error-prone, because particular instances are readily confused w/ one another and may lead to param/arg mis-ordering. since `flowGroup` is less-specific than `flowName`, my habit is to put it first, which appears to be how `MetricRegistry.name` wants them as well... and yet they're swapped in this method's params. let's seek uniform consistency, so a misordering easily jumps out at maintainers. nonetheless, even better, would be to replace the two `String` params w/ a single `FlowId` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
