[
https://issues.apache.org/jira/browse/GOBBLIN-1876?focusedWorklogId=876242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876242
]
ASF GitHub Bot logged work on GOBBLIN-1876:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/23 01:13
Start Date: 15/Aug/23 01:13
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3738:
URL: https://github.com/apache/gobblin/pull/3738#discussion_r1294099468
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java:
##########
@@ -337,4 +340,24 @@ public void close() throws IOException {
public long getHighWatermark() {
return 0;
}
+
+ public static String getKafkaBrokerSimpleName(State state) {
Review Comment:
Can we consider putting this method directly under the common utils? Also
return list of broker name if there are more than one broker specified? We can
rely on downstream method to determine whether there should be 1 broker or more
broker in the brokers config?
Issue Time Tracking
-------------------
Worklog Id: (was: 876242)
Time Spent: 0.5h (was: 20m)
> Kafka source / extractor utility to get a simple name for kafka brokers
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1876
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1876
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This utility can be used to write human readable names for the URIs that can
> be used in Gobblin tracking events, Gobblin Metadata Change Events
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
