[
https://issues.apache.org/jira/browse/GOBBLIN-1876?focusedWorklogId=876399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876399
]
ASF GitHub Bot logged work on GOBBLIN-1876:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/23 20:08
Start Date: 15/Aug/23 20:08
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3738:
URL: https://github.com/apache/gobblin/pull/3738#discussion_r1295044694
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -916,7 +916,7 @@ public class ConfigurationKeys {
* Kafka job configurations.
*/
public static final String KAFKA_BROKERS = "kafka.brokers";
- public static final String KAFKA_BROKER_TO_SIMPLE_NAME_MAP_KEY =
ConfigurationKeys.KAFKA_BROKERS + ".simpleNameMap";
+ public static final String KAFKA_BROKER_TO_SIMPLE_NAME_MAP_KEY =
ConfigurationKeys.KAFKA_BROKERS + "ToSimpleNameMap";
Review Comment:
this definition is a little wired. Can you just change it to be
"kafka.brokersToSimpleNameMap"
Issue Time Tracking
-------------------
Worklog Id: (was: 876399)
Time Spent: 1h 10m (was: 1h)
> Kafka source / extractor utility to get a simple name for kafka brokers
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1876
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1876
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This utility can be used to write human readable names for the URIs that can
> be used in Gobblin tracking events, Gobblin Metadata Change Events
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
