[
https://issues.apache.org/jira/browse/GOBBLIN-1882?focusedWorklogId=877101&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877101
]
ASF GitHub Bot logged work on GOBBLIN-1882:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/23 21:19
Start Date: 18/Aug/23 21:19
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3745:
URL: https://github.com/apache/gobblin/pull/3745#discussion_r1298872650
##########
gobblin-modules/gobblin-kafka-common/src/test/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaProduceRateTrackerTest.java:
##########
@@ -58,6 +59,7 @@ public void setUp() {
kafkaPartitions.add(new
KafkaPartition.Builder().withTopicName("test-topic").withId(1).build());
this.workUnitState = new WorkUnitState();
this.workUnitState.setProp(KafkaSource.RECORD_LEVEL_SLA_MINUTES_KEY, 5L);
+ this.workUnitState.setProp(ConfigurationKeys.KAFKA_BROKERS, "testBroker");
Review Comment:
Why do we set this in the tests? Do these tests even test the
eventSubmitters?
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java:
##########
@@ -354,10 +354,12 @@ public static String getKafkaBrokerSimpleName(State
state) {
String brokerUri = kafkaBrokerUriList.get(0);
Map<String, String> brokerToSimpleName =
KafkaCommonUtil.getKafkaBrokerToSimpleNameMap(state);
- Preconditions.checkArgument(brokerToSimpleName.get(brokerUri) != null,
- String.format("Unable to find simple name for the kafka cluster broker
uri in the config. Please check the map "
- + "value of %s. brokerUri=%s, configMapValue=%s",
KAFKA_BROKERS_TO_SIMPLE_NAME_MAP_KEY, brokerUri, brokerToSimpleName));
-
+ if (!brokerToSimpleName.containsKey(brokerUri)) {
+ LOG.warn(String.format(
Review Comment:
minor nit: string.format isn't necessary for logger
Issue Time Tracking
-------------------
Worklog Id: (was: 877101)
Time Spent: 0.5h (was: 20m)
> Add brokerName in metric emitted from KafkaStreamingExtractor
> -------------------------------------------------------------
>
> Key: GOBBLIN-1882
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1882
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Reporter: Zihan Li
> Assignee: Shirshanka Das
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add brokerName in metric emitted from KafkaStreamingExtractor, so it can help
> us better monitor the overall performance of the system
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
