[
https://issues.apache.org/jira/browse/GOBBLIN-1882?focusedWorklogId=877108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877108
]
ASF GitHub Bot logged work on GOBBLIN-1882:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/23 00:11
Start Date: 19/Aug/23 00:11
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3745:
URL: https://github.com/apache/gobblin/pull/3745#discussion_r1298939656
##########
gobblin-modules/gobblin-kafka-common/src/test/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaProduceRateTrackerTest.java:
##########
@@ -58,6 +59,7 @@ public void setUp() {
kafkaPartitions.add(new
KafkaPartition.Builder().withTopicName("test-topic").withId(1).build());
this.workUnitState = new WorkUnitState();
this.workUnitState.setProp(KafkaSource.RECORD_LEVEL_SLA_MINUTES_KEY, 5L);
+ this.workUnitState.setProp(ConfigurationKeys.KAFKA_BROKERS, "testBroker");
Review Comment:
They do not, but the producerate/consumRate tracker call the util method
which assume we do have broker defined.
Issue Time Tracking
-------------------
Worklog Id: (was: 877108)
Time Spent: 40m (was: 0.5h)
> Add brokerName in metric emitted from KafkaStreamingExtractor
> -------------------------------------------------------------
>
> Key: GOBBLIN-1882
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1882
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Reporter: Zihan Li
> Assignee: Shirshanka Das
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add brokerName in metric emitted from KafkaStreamingExtractor, so it can help
> us better monitor the overall performance of the system
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
