[
https://issues.apache.org/jira/browse/GOBBLIN-1889?focusedWorklogId=878690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878690
]
ASF GitHub Bot logged work on GOBBLIN-1889:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Aug/23 17:35
Start Date: 28/Aug/23 17:35
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3752:
URL: https://github.com/apache/gobblin/pull/3752#discussion_r1307718403
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/ServiceMetricNames.java:
##########
@@ -65,4 +65,8 @@ public class ServiceMetricNames {
public static final String HELIX_LEADER_STATE = "HelixLeaderState";
public static final String FLOWGRAPH_UPDATE_FAILED_METER =
GOBBLIN_SERVICE_PREFIX + ".FlowgraphUpdateFailed";
+
+ public static final String DAG_COUNT_MYSQL_DAG_STATE_COUNT =
GOBBLIN_SERVICE_PREFIX + ".MysqlDagStateStore" + ".totalDagCount";
+
+ public static final String DAG_COUNT_FS_DAG_STATE_COUNT =
GOBBLIN_SERVICE_PREFIX + ".FsDagStateStore" + ".totalDagCount";
Review Comment:
do we need these to have separate names? what if we have it as one metric
and we can distinguish which store is used from configs deployed? how do we
handle this for other cases like the `quotaManager` where we have multiple
implementations that could be used?
Issue Time Tracking
-------------------
Worklog Id: (was: 878690)
Time Spent: 20m (was: 10m)
> Create Metric for Total Number of Dags in Dag State Store
> ---------------------------------------------------------
>
> Key: GOBBLIN-1889
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1889
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
