[
https://issues.apache.org/jira/browse/GOBBLIN-1889?focusedWorklogId=878995&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878995
]
ASF GitHub Bot logged work on GOBBLIN-1889:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/23 05:21
Start Date: 30/Aug/23 05:21
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3752:
URL: https://github.com/apache/gobblin/pull/3752#discussion_r1309675156
##########
gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/ServiceMetricNames.java:
##########
@@ -65,4 +65,8 @@ public class ServiceMetricNames {
public static final String HELIX_LEADER_STATE = "HelixLeaderState";
public static final String FLOWGRAPH_UPDATE_FAILED_METER =
GOBBLIN_SERVICE_PREFIX + ".FlowgraphUpdateFailed";
+
+ public static final String DAG_COUNT_MYSQL_DAG_STATE_COUNT =
GOBBLIN_SERVICE_PREFIX + ".MysqlDagStateStore" + ".totalDagCount";
+
+ public static final String DAG_COUNT_FS_DAG_STATE_COUNT =
GOBBLIN_SERVICE_PREFIX + ".FsDagStateStore" + ".totalDagCount";
Review Comment:
I believe having separate names would help for better tracking, especially
to understand how many `FSDagStateStore`s are still in use. Thus, the idea is
separate it at individual impl. level to track the metrics better, rather
having to combine them... and for cases like `quotaManager` might not arise
here since we would have only impl. used at any given time per service
deployment
Issue Time Tracking
-------------------
Worklog Id: (was: 878995)
Time Spent: 40m (was: 0.5h)
> Create Metric for Total Number of Dags in Dag State Store
> ---------------------------------------------------------
>
> Key: GOBBLIN-1889
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1889
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
