Will-Lo commented on code in PR #3764:
URL: https://github.com/apache/gobblin/pull/3764#discussion_r1319180650
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java:
##########
@@ -525,11 +532,19 @@ static boolean
isCustomizedProgressReportEnabled(Properties properties) {
&&
Boolean.parseBoolean(properties.getProperty(ENABLED_CUSTOMIZED_PROGRESS));
}
- static boolean isMapperFailureFatalEnabled(Properties properties) {
- return (
-
properties.containsKey(ConfigurationKeys.MR_JOB_MAPPER_FAILURE_IS_FATAL_KEY)
- &&
Boolean.parseBoolean(properties.getProperty(ConfigurationKeys.MR_JOB_MAPPER_FAILURE_IS_FATAL_KEY)))
- || ConfigurationKeys.DEFAULT_MR_JOB_MAPPER_FAILURE_IS_FATAL;
+ static boolean isBooleanPropEnabled(Properties props, String propKey,
Optional<Boolean> optDefault) {
Review Comment:
I may be misunderstanding the purpose of this here, but if the way this is
being invoked is through passing an `Optional.of(<static_variable>)`, then
wouldn't that just resolve to a default value we can use instead of wrapping it
around an optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
